Issue 18176: Linux: stroke font outlines....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18176: Linux: stroke font outlines.... (Closed)

Created:
11 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: stroke font outlines. TEST=LayoutTests/svg/custom/pointer-events-text.svg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8312

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -9 lines)			Patch
	M	third_party/WebKit/WebCore/platform/graphics/chromium/FontLinux.cpp	View	1	2 chunks	+32 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM http://codereview.chromium.org/18176/diff/1/2 File third_party/WebKit/WebCore/platform/graphics/chromium/FontLinux.cpp (right): http://codereview.chromium.org/18176/diff/1/2#newcode78 Line 78: if (textMode & cTextFill) { Are cTextFill ...

11 years, 11 months ago (2009-01-16 22:12:39 UTC) #2

Evan Stade

11 years, 11 months ago (2009-01-16 22:23:11 UTC) #3

Yea, we do draw twice. That's the same thing that FontChromiumWin does. I'll add
a comment.

Expand Messages | Collapse Messages

Issue 18176: Linux: stroke font outlines.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages