Issue 18173: "Port" StackTrace to Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18173: "Port" StackTrace to Mac (Closed)

Created:
11 years, 11 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

"Port" StackTrace to Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8229

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -31 lines)			Patch
M	base/debug_util.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/debug_util_posix.cc	View	1	3 chunks	+2 lines, -26 lines	1 comment	Download
M	base/debug_util_win.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 11 months ago (2009-01-16 22:02:47 UTC) #2

LGTM

http://codereview.chromium.org/18173/diff/204/5
File base/debug_util_posix.cc (left):

http://codereview.chromium.org/18173/diff/204/5#oldcode9
Line 9: #include <unistd.h>
unistd is needed for STDERR_FILENO

Expand Messages | Collapse Messages