Issue 1817: Remove bspatch from linux build targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1817: Remove bspatch from linux build targets. (Closed)

Created:
12 years, 3 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
evanm, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove bspatch from linux build targets. TBR=sgk,evanm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1853

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	build/SConscript.main	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

12 years, 3 months ago (2008-09-08 18:38:57 UTC) #2

http://codereview.chromium.org/1817/diff/1/2
File build/SConscript.main (left):

http://codereview.chromium.org/1817/diff/1/2#oldcode463
Line 463: '$BSPATCH_DIR/SConscript',
Unconditionally removing $BSPATCH_DIR/SConscript from this list will break the
SCons build on Windows, which still needs bspatch for its build of setup.  It
needs to be added to the list only if env['PLATFORM'] not in ('darwin',
'posix'), since I presume bspatch also doesn't build on Mac yet...?  (The Mac
build is getting SCons-ified this week.)

Expand Messages | Collapse Messages