Issue 1816004: Change the path of qualified_components to the autotest directory.

Issue 1816004: Change the path of qualified_components to the autotest directory. (Closed)

Created:
10 years, 7 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Tammo Spalink, Nick Sanders, kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromiumos

Visibility:
Public.

Description

Change the path of qualified_components to the autotest directory. So no need of the directory /usr/local/manufacturing/.

Patch Set 2 : Check file exists #

Patch Set 4 : Fix name #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	src/scripts/mod_for_factory_scripts/400configAutotest	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
	M	src/scripts/mod_for_factory_scripts/500copyQualDb	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM Small modifications http://codereview.chromium.org/1816004/diff/1/2 File src/scripts/mod_for_factory_scripts/400configAutotest (right): http://codereview.chromium.org/1816004/diff/1/2#newcode7 src/scripts/mod_for_factory_scripts/400configAutotest:7: echo "Create global_config.ini in autotest directory." ...

10 years, 7 months ago (2010-05-04 01:06:55 UTC) #2

Tom Wai-Hong Tam

10 years, 7 months ago (2010-05-04 08:59:20 UTC) #3

http://codereview.chromium.org/1816004/diff/1/2
File src/scripts/mod_for_factory_scripts/400configAutotest (right):

http://codereview.chromium.org/1816004/diff/1/2#newcode7
src/scripts/mod_for_factory_scripts/400configAutotest:7: echo "Create
global_config.ini in autotest directory."
On 2010/05/04 01:06:55, kmixter1 wrote:
> Do you want to give an error if the file already exists?  Just in case we need
> to merge stuff later.  I suspect we'll want to do something like this for
> non-factory testing too.

Done.

http://codereview.chromium.org/1816004/diff/1/3
File src/scripts/mod_for_factory_scripts/500copyQualDb (right):

http://codereview.chromium.org/1816004/diff/1/3#newcode26
src/scripts/mod_for_factory_scripts/500copyQualDb:26:
${STATEFUL_DIR}/usr/local/autotest/site_tests/hardware_Components/qualified_components
On 2010/05/04 01:06:55, kmixter1 wrote:
> >80chars. May want to create .../hardware_Components in another variable and
> just do cp -f ${QUALDB} ${COMPONENTS_DIR}

Done.

Expand Messages | Collapse Messages