Issue 1816001: Bookmark manager: Tweak the top bar behavior a bit....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1816001: Bookmark manager: Tweak the top bar behavior a bit.... (Closed)

Created:
10 years, 7 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
feldstein

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bookmark manager: Tweak the top bar behavior a bit. Empty searches are not shown now, instead we go to "Bookmarks bar" folder. Clicking the logo button clears the search and takes the user to the "Bookmarks bar" folder. BUG=None TEST=See above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45995

Patch Set 1 #

Patch Set 2 : Removed useless call to preventDefault #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/main.html	View	1	3 chunks	+18 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

feldstein

10 years, 7 months ago (2010-04-29 21:01:33 UTC) #2

LGTM after clarification or removal of preventDefault call.

Expand Messages | Collapse Messages