Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 18143: Change the handling of catch blocks to use context extension objects... (Closed)

Created:
11 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change the handling of catch blocks to use context extension objects instead of normal JSObjects. This ensures that __proto__ and accessors on the Object prototype do not interfere with catch scopes. Also, it fixes the bug that catch variables were not DontDelete (issue 74). Next step is to create special lookup routines for context extension objects and remove the special handling of context extension objects from the general javascript object lookup routines. Committed: http://code.google.com/p/v8/source/detail?r=1091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -36 lines) Patch
M src/ast.h View 2 chunks +21 lines, -0 lines 0 comments Download
M src/codegen-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/codegen-ia32.cc View 2 chunks +12 lines, -1 line 0 comments Download
M src/parser.cc View 3 chunks +2 lines, -31 lines 0 comments Download
M src/prettyprinter.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/rewriter.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/usage-analyzer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-74.js View 1 chunk +41 lines, -0 lines 0 comments Download
A test/mjsunit/try-catch-extension-object.js View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 11 months ago (2009-01-16 09:18:33 UTC) #1
Kevin Millikin (Chromium)
11 years, 11 months ago (2009-01-16 09:40:06 UTC) #2
STV.

Powered by Google App Engine
This is Rietveld 408576698