Issue 1812008: Revert http://codereview.chromium.org/1818001 so that archived build can produce test images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1812008: Revert http://codereview.chromium.org/1818001 so that archived build can produce test images (Closed)

Created:
10 years, 7 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1, ericli

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Revert http://codereview.chromium.org/1818001 so that archived build can produce test images

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	src/scripts/mod_image_for_test.sh	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 7 months ago (2010-04-30 22:52:41 UTC) #3

LGTM

Please add BUG=3026 to description (even tho ericli points out that
the linking does not work correctly).

On Fri, Apr 30, 2010 at 3:46 PM,  <ericli@chromium.org> wrote:
> LGTM
>
> On 2010/04/30 22:44:27, sosa wrote:
>
>
>
>
> http://codereview.chromium.org/1812008/show
>

Expand Messages | Collapse Messages