Move stack check into AllocateStackSlots so the load delay can be...

Move stack check into AllocateStackSlots so the load delay can be
interleaved with other instructions.  Reorder the stack check
slightly to avoid some load delay. The end result is almost
imperceptible.

Committed: http://code.google.com/p/v8/source/detail?r=2784

[Mads Ager (chromium), 2009-08-31 09:33:10]

LGTM

http://codereview.chromium.org/181019/diff/1/3
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/181019/diff/1/3#newcode1114
Line 1114: // Put the lr setup insn in the delay slot.  The '4' is added to the
insn -> instruction

http://codereview.chromium.org/181019/diff/1/3#newcode1115
Line 1115: // implicit 8 that always apples to operations with pc and gives a
return
applies?

http://codereview.chromium.org/181019/diff/1/3#newcode1117
Line 1117: masm_->add(lr, pc, Operand(4));
Is this just 4 bytes or is it really kPointerSize?

[Erik Corry, 2009-08-31 11:07:57]

http://codereview.chromium.org/181019/diff/1/3
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/181019/diff/1/3#newcode1117
Line 1117: masm_->add(lr, pc, Operand(4));
On 2009/08/31 09:33:10, Mads Ager wrote:
> Is this just 4 bytes or is it really kPointerSize?

Fixed to be sizeof(Instr).  If we move to thumb2 we shall have to revisit this
since thumb2 has variable length instructions.