Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: webkit/tools/test_shell/test_webview_delegate_gtk.cc

Issue 181014: Eliminate remaining WebCore dependencies from webplugin_impl.cc... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_webview_delegate_gtk.cc
===================================================================
--- webkit/tools/test_shell/test_webview_delegate_gtk.cc (revision 25087)
+++ webkit/tools/test_shell/test_webview_delegate_gtk.cc (working copy)
@@ -82,40 +82,8 @@
} // namespace
-// WebViewDelegate -----------------------------------------------------------
+// WebViewDelegate ------------------------------------------------------------
-WebPluginDelegate* TestWebViewDelegate::CreatePluginDelegate(
- WebView* webview,
- const GURL& url,
- const std::string& mime_type,
- const std::string& clsid,
- std::string* actual_mime_type) {
- bool allow_wildcard = true;
- WebPluginInfo info;
- if (!NPAPI::PluginList::Singleton()->GetPluginInfo(url, mime_type, clsid,
- allow_wildcard, &info,
- actual_mime_type))
- return NULL;
-
- const std::string& mtype =
- (actual_mime_type && !actual_mime_type->empty()) ? *actual_mime_type
- : mime_type;
- // TODO(evanm): we probably shouldn't be doing this mapping to X ids at
- // this level.
- GdkNativeWindow plugin_parent =
- GDK_WINDOW_XWINDOW(shell_->webViewHost()->view_handle()->window);
-
- return WebPluginDelegateImpl::Create(info.path, mtype, plugin_parent);
-}
-
-void TestWebViewDelegate::CreatedPluginWindow(gfx::PluginWindowHandle id) {
- shell_->webViewHost()->CreatePluginContainer(id);
-}
-
-void TestWebViewDelegate::WillDestroyPluginWindow(gfx::PluginWindowHandle id) {
- shell_->webViewHost()->DestroyPluginContainer(id);
-}
-
void TestWebViewDelegate::ShowJavaScriptAlert(const std::wstring& message) {
GtkWidget* dialog = gtk_message_dialog_new(
shell_->mainWnd(), GTK_DIALOG_MODAL, GTK_MESSAGE_INFO,
@@ -125,6 +93,8 @@
gtk_widget_destroy(dialog);
}
+// WebWidgetClient ------------------------------------------------------------
+
void TestWebViewDelegate::show(WebNavigationPolicy policy) {
WebWidgetHost* host = GetWidgetHost();
GtkWidget* drawing_area = host->view_handle();
@@ -220,16 +190,54 @@
return WebRect();
}
-void TestWebViewDelegate::DidMovePlugin(const WebPluginGeometry& move) {
+void TestWebViewDelegate::runModal() {
+ NOTIMPLEMENTED();
+}
+
+// WebPluginPageDelegate ------------------------------------------------------
+
+webkit_glue::WebPluginDelegate* TestWebViewDelegate::CreatePluginDelegate(
+ const GURL& url,
+ const std::string& mime_type,
+ const std::string& clsid,
+ std::string* actual_mime_type) {
+ bool allow_wildcard = true;
+ WebPluginInfo info;
+ if (!NPAPI::PluginList::Singleton()->GetPluginInfo(url, mime_type, clsid,
+ allow_wildcard, &info,
+ actual_mime_type))
+ return NULL;
+
+ const std::string& mtype =
+ (actual_mime_type && !actual_mime_type->empty()) ? *actual_mime_type
+ : mime_type;
+ // TODO(evanm): we probably shouldn't be doing this mapping to X ids at
+ // this level.
+ GdkNativeWindow plugin_parent =
+ GDK_WINDOW_XWINDOW(shell_->webViewHost()->view_handle()->window);
+
+ return WebPluginDelegateImpl::Create(info.path, mtype, plugin_parent);
+}
+
+void TestWebViewDelegate::CreatedPluginWindow(
+ gfx::PluginWindowHandle id) {
+ shell_->webViewHost()->CreatePluginContainer(id);
+}
+
+void TestWebViewDelegate::WillDestroyPluginWindow(
+ gfx::PluginWindowHandle id) {
+ shell_->webViewHost()->DestroyPluginContainer(id);
+}
+
+void TestWebViewDelegate::DidMovePlugin(
+ const webkit_glue::WebPluginGeometry& move) {
WebWidgetHost* host = GetWidgetHost();
GtkPluginContainerManager* plugin_container_manager =
static_cast<WebViewHost*>(host)->plugin_container_manager();
plugin_container_manager->MovePluginContainer(move);
}
-void TestWebViewDelegate::runModal() {
- NOTIMPLEMENTED();
-}
+// Public methods -------------------------------------------------------------
void TestWebViewDelegate::UpdateSelectionClipboard(bool is_empty_selection) {
if (is_empty_selection)
@@ -252,7 +260,7 @@
gtk_target_table_free(targets, num_targets);
}
-// Private methods -----------------------------------------------------------
+// Private methods ------------------------------------------------------------
void TestWebViewDelegate::SetPageTitle(const std::wstring& title) {
gtk_window_set_title(GTK_WINDOW(shell_->mainWnd()),

Powered by Google App Engine
This is Rietveld 408576698