Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: webkit/glue/plugins/webplugin_delegate_impl.cc

Issue 181014: Eliminate remaining WebCore dependencies from webplugin_impl.cc... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/plugins/webplugin_delegate_impl.cc
===================================================================
--- webkit/glue/plugins/webplugin_delegate_impl.cc (revision 25087)
+++ webkit/glue/plugins/webplugin_delegate_impl.cc (working copy)
@@ -21,6 +21,9 @@
#include "webkit/glue/plugins/plugin_stream_url.h"
#include "webkit/glue/webkit_glue.h"
+using webkit_glue::WebPlugin;
+using webkit_glue::WebPluginDelegate;
+using webkit_glue::WebPluginResourceClient;
using WebKit::WebCursorInfo;
using WebKit::WebKeyboardEvent;
using WebKit::WebInputEvent;
@@ -30,17 +33,17 @@
const FilePath& filename,
const std::string& mime_type,
gfx::PluginWindowHandle containing_view) {
- scoped_refptr<NPAPI::PluginLib> plugin =
+ scoped_refptr<NPAPI::PluginLib> plugin_lib =
NPAPI::PluginLib::CreatePluginLib(filename);
- if (plugin.get() == NULL)
+ if (plugin_lib.get() == NULL)
return NULL;
- NPError err = plugin->NP_Initialize();
+ NPError err = plugin_lib->NP_Initialize();
if (err != NPERR_NO_ERROR)
return NULL;
scoped_refptr<NPAPI::PluginInstance> instance =
- plugin->CreateInstance(mime_type);
+ plugin_lib->CreateInstance(mime_type);
return new WebPluginDelegateImpl(containing_view, instance.get());
}
@@ -52,7 +55,7 @@
bool load_manually) {
plugin_ = plugin;
- instance_->set_web_plugin(plugin);
+ instance_->set_web_plugin(plugin_);
NPAPI::PluginInstance* old_instance =
NPAPI::PluginInstance::SetInitializingInstance(instance_);
@@ -86,7 +89,7 @@
instance_->set_window_handle(parent_);
}
- PlatformInitialize(plugin);
+ PlatformInitialize();
plugin_url_ = url.spec();

Powered by Google App Engine
This is Rietveld 408576698