Eliminate remaining WebCore dependencies from webplugin_impl.cc...

Eliminate remaining WebCore dependencies from webplugin_impl.cc

Introduces WebPluginPageDelegate to hold the methods that only
existed on WebViewDelegate to allow WebPluginImpl to talk to the
RenderView.  This enables us to eliminate those methods from
WebViewDelegate, which eliminates the last dependency on gfx/
native_widget_types.h in our WebKit interface!

WebViewDelegate grows a CreatePlugin method that returns a
WebKit::WebPlugin.  It loses its CreatePluginDelegate method,
which now lives on WebPluginPageDelegate.

This change makes RenderView use WeakPtr when it hands itself to
each WebPluginDelegateProxy and WebPluginImpl instance.  This
makes the memory management simpler.

This change also moves various WebPlugin* interfaces defined in
webkit/glue into the webkit_glue namespace.  This was to help
reduce confusion with similarly named types in the WebKit
namespace.

WebKit::WebPluginParams is added to contain the set of parameters
used to construct a plugin.

WebPluginContainer gets a couple more methods to allow us to avoid
WebCore dependencies in WebPluginImpl.

R=jam
BUG=10036
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25184

[darin (slow to review), 2009-09-01 22:58:54]

Sorry for the huge CL!  This is the last of the big plugin changes :)

[jam, 2009-09-02 00:03:01]

http://codereview.chromium.org/181014/diff/3175/3214
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/181014/diff/3175/3214#newcode253
Line 253: void RenderView::PluginDestroyed(WebPluginDelegateProxy* proxy) {
It doesn't look like this function is being called in WebPluginDelegateProxy
anymore?  If so this function can be taken out, but we'll need to use WeakPtr
for first_default_plugin_ or something similar to avoid the plugin going away
while we're holding on to a pointer to it.

http://codereview.chromium.org/181014/diff/3175/3201
File net/url_request/url_request_job_tracker.cc (right):

http://codereview.chromium.org/181014/diff/3175/3201#newcode10
Line 10: #include "net/url_request/url_request.h"
is this part of a different change?

http://codereview.chromium.org/181014/diff/3175/3188
File webkit/glue/webplugin_delegate.cc (left):

http://codereview.chromium.org/181014/diff/3175/3188#oldcode1
Line 1: // Copyright (c) 2009 The Chromium Authors. All rights reserved.
question: is this file deleted or did you make it empty?  Rietveld is showing
its status as "M" instead of "D".

http://codereview.chromium.org/181014/diff/3175/3180
File webkit/glue/webplugin_page_delegate.h (right):

http://codereview.chromium.org/181014/diff/3175/3180#newcode24
Line 24: // platform-neutral
will be gone soon hopefully :)

[darin (slow to review), 2009-09-02 16:20:08]

Please take another look.  RenderView::first_default_plugin_ is now a
WeakPtr<WebPluginDelegateProxy>.  I removed the RenderView::PluginDestroyed
callback.  For this change, I also realized that it would be good if WeakPtr<T>
had a reset method, so I added one.

The url_request_job_tracker.cc change was indeed unintended as part of this CL. 
Removed.

Locally, webplugin_delegate.cc is svn removed.

[jam, 2009-09-02 17:06:30]

lgtm

http://codereview.chromium.org/181014/diff/10001/10036
File chrome/renderer/render_view.h (right):

http://codereview.chromium.org/181014/diff/10001/10036#newcode369
Line 369: //XXX void PluginDestroyed(WebPluginDelegateProxy* proxy);
nit: remove