Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: chrome/browser/cocoa/browser_window_controller_unittest.mm

Issue 181002: Reverting 24700. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/cocoa/download_item_cell.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/browser_window_controller_unittest.mm (revision 24707)
+++ chrome/browser/cocoa/browser_window_controller_unittest.mm (working copy)
@@ -179,6 +179,7 @@
NSView* contentView = [[tabstrip window] contentView];
NSView* toolbar = [controller_ toolbarView];
NSView* infobar = [controller_ infoBarContainerView];
+ NSView* contentArea = [controller_ tabContentArea];
// We need to muck with the views a bit to put us in a consistent state before
// we start resizing. In particular, we need to move the tab strip to be
@@ -191,14 +192,9 @@
[tabstrip setFrame:tabstripFrame];
// Make sure each view is as tall as we expect.
- ASSERT_EQ(36, NSHeight([toolbar frame]));
+ ASSERT_EQ(39, NSHeight([toolbar frame]));
ASSERT_EQ(0, NSHeight([infobar frame]));
-
- // TODO(rohitrao):rewrite and reenable
-#if 0
- NSView* contentArea = [controller_ tabContentArea];
-
// Force a layout and check each view's frame.
// contentView should be at 0,0 800x600
// contentArea should be at 0,0 800x561
@@ -259,7 +255,6 @@
EXPECT_TRUE(NSEqualRects([contentArea frame], NSMakeRect(0, 30, 800, 531)));
EXPECT_TRUE(NSEqualRects([infobar frame], NSMakeRect(0, 561, 800, 0)));
EXPECT_TRUE(NSEqualRects([toolbar frame], NSMakeRect(0, 561, 800, 39)));
-#endif
}
TEST_F(BrowserWindowControllerTest, TestTopLeftForBubble) {
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/cocoa/download_item_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698