Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: gcl.py

Issue 1810009: Make commit logs not have an extra http:// (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 45834)
+++ gcl.py (working copy)
@@ -892,9 +892,10 @@
commit_message = change_info.description.replace('\r\n', '\n')
if change_info.issue:
- commit_message += ('\nReview URL: http://%s/%d' %
- (GetCodeReviewSetting("CODE_REVIEW_SERVER"),
- change_info.issue))
+ server = GetCodeReviewSetting("CODE_REVIEW_SERVER")
+ if not server.startswith("http://") and not server.startswith("https://"):
+ server = "http://" + server
+ commit_message += ('\nReview URL: %s/%d' % (server, change_info.issue))
handle, commit_filename = tempfile.mkstemp(text=True)
os.write(handle, commit_message)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698