Added handles to the mirror objects. When a mirror for an object is created...

Added handles to the mirror objects. When a mirror for an object is created
it is assigned a numeric handle. Handles are used to make a 1:1
correspondence between objects and mirrors. Currently the mirrors are
cached in a JavaScript array and when creating a mirror this cache is
checked to see if a mirror already exists for the object. This cache is
cleared when leaving the debugger.

Changed the serialization format to take advantage of these handles. When
an object is serialized referenced objects are represented just by their
handle id serialized as '{ref:<handle>}'. During serialization the
referenced handles are collected and the serializer can provide a
serialization of all the referenced objects.

Removed the special handling of array properties. Indexed properties and
the length property are now rendered as named properties in the
serialization.

Removed the special serialization handling of RegExp properties. The
properties 'source', 'global', 'ignoreCase' and 'multiline' are serialized
with the rest of the properties.

Changed a lot of tests to handle the changed format.

Committed: http://code.google.com/p/v8/source/detail?r=1093

[Mads Ager (chromium), 2009-01-15 18:52:06]

LGTM

http://codereview.chromium.org/18092/diff/1/18
File src/mirror-delay.js (right):

http://codereview.chromium.org/18092/diff/1/18#newcode93
Line 93: * Returns the mirror for the undifined value.
undifined -> undefined.

http://codereview.chromium.org/18092/diff/1/18#newcode1657
Line 1657: JSONProtocolSerializer.prototype.serialize_ = function(mirror,
reference, details) {
line too long?

http://codereview.chromium.org/18092/diff/1/18#newcode1758
Line 1758: JSONProtocolSerializer.prototype.serializeObject_ = function(mirror,
content, details) {
Line too long?

[Søren Thygesen Gjesse, 2009-01-16 10:38:36]

http://codereview.chromium.org/18092/diff/1/18
File src/mirror-delay.js (right):

http://codereview.chromium.org/18092/diff/1/18#newcode93
Line 93: * Returns the mirror for the undifined value.
On 2009/01/15 18:52:06, Mads Ager wrote:
> undifined -> undefined.

Done.

http://codereview.chromium.org/18092/diff/1/18#newcode1657
Line 1657: JSONProtocolSerializer.prototype.serialize_ = function(mirror,
reference, details) {
On 2009/01/15 18:52:06, Mads Ager wrote:
> line too long?

Done.

http://codereview.chromium.org/18092/diff/1/18#newcode1758
Line 1758: JSONProtocolSerializer.prototype.serializeObject_ = function(mirror,
content, details) {
On 2009/01/15 18:52:06, Mads Ager wrote:
> Line too long?

Done.