Remove proxy_mode_ from the HttpNetworkTransaction since it...

Remove proxy_mode_ from the HttpNetworkTransaction since it
is redundant with proxy_info_.

BUG=none
TEST=covered by existing tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45787

[vandebo (ex-Chrome), 2010-04-28 01:11:58]

Modulo compile errors, LGTM.

[vandebo (ex-Chrome), 2010-04-28 01:14:27]

http://codereview.chromium.org/1809001/diff/5001/6003
File net/proxy/proxy_info.h (right):

http://codereview.chromium.org/1809001/diff/5001/6003#newcode55
net/proxy/proxy_info.h:55: return proxy_server().is_http();
I believe proxy_server() can return NULL.  See is_direct()

[Mike Belshe, 2010-04-28 02:49:33]

On 2010/04/28 01:14:27, vandebo wrote:
> http://codereview.chromium.org/1809001/diff/5001/6003
> File net/proxy/proxy_info.h (right):
> 
> http://codereview.chromium.org/1809001/diff/5001/6003#newcode55
> net/proxy/proxy_info.h:55: return proxy_server().is_http();
> I believe proxy_server() can return NULL.  See is_direct()

Good point.  This turns out not to be an issue in practice because the
ResolveProxy call always puts at least one entry into the list.

The is_direct() returning false when the list is empty is questionable to me -
it seems that it should.  But I decided not to change that.

[vandebo (ex-Chrome), 2010-04-28 04:29:14]

LGTM