Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 18090: Fix issue 191:... (Closed)

Created:
11 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 191: http://code.google.com/p/v8/issues/detail?id=191 Accessor setters should not be called for eval-introduced context extension objects. This change fixes the issue, but I think it is time to separate out the lookup routines for eval-introduced context extension objects. There is no reason to use the general lookup routines for this. I'll do that in a separate changelist. Committed: http://code.google.com/p/v8/source/detail?r=1076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-191.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 11 months ago (2009-01-15 11:25:55 UTC) #1
Christian Plesner Hansen
11 years, 11 months ago (2009-01-15 11:29:59 UTC) #2
Lgtm

Powered by Google App Engine
This is Rietveld 408576698