We should download text/csv mime types instead of displaying them....

We should download text/csv mime types instead of displaying them.

BUG=6079
R=darin


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8087

[darin (slow to review), 2009-01-15 06:09:19]

This change appears to match WebKit/win/WebView.cpp's canShowMIMEType function,
so LGTM.

[darin (slow to review), 2009-01-15 06:10:06]

Although... if the C-D header were not present, would we still end up
downloading the text/csv file?  It seems like we should still default to showing
text/* files if possible.

[abarth-chromium, 2009-01-15 07:08:04]

> It seems like we should still default to showing
> text/* files if possible.

Neither Firefox nor Safari show text/csv.  Our behavior in this case is exactly
what the reporter is complaining about.

[darin (slow to review), 2009-01-15 07:11:46]

Yeah, I know... it is just one of those things that I always found annoying
about browsers.  If it is a text file, let me see it please.

Anyways, this change LGTM on the basis of matching other browsers.  Maybe the
solution is to add a "view as text" feature to our download manager so that if a
download is forced upon a user, they could still choose to view it instead.

[PhistucK, 2009-01-15 07:41:30]

On 2009/01/15 07:11:46, darin wrote:
> Yeah, I know... it is just one of those things that I always found annoying
> about browsers.  If it is a text file, let me see it please.
> 
> Anyways, this change LGTM on the basis of matching other browsers.  Maybe the
> solution is to add a "view as text" feature to our download manager so that if
a
> download is forced upon a user, they could still choose to view it instead.

I strongly support that ("view as text" feature). Sometimes you just really do
not want to download stuff, but simply to see them in the browser for a quick
look.