Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 1807002: Correctly align memory allocations in the case where we need to allocate memo... (Closed)

Created:
10 years, 8 months ago by Markus (顧孟勤)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, agl
Visibility:
Public.

Description

Correctly align memory allocations in the case where we need to allocate memory as far away from the stack as possible, but still as close to the VDSO as we can. BUG=none TEST=run the tests in a tight loop and notice that they no longer randomly fail Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45775

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sandbox/linux/seccomp/maps.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Markus (顧孟勤)
Without this change and depending on the exact memory layout picked by ASR, the sandbox ...
10 years, 8 months ago (2010-04-28 01:24:22 UTC) #1
Evan Martin
10 years, 8 months ago (2010-04-28 01:36:40 UTC) #2
LGTM with math fix

http://codereview.chromium.org/1807002/diff/1/2
File sandbox/linux/seccomp/maps.cc (right):

http://codereview.chromium.org/1807002/diff/1/2#newcode224
sandbox/linux/seccomp/maps.cc:224: position = (addr - kMaxDistance) & ~0x3FFF;
math error

Powered by Google App Engine
This is Rietveld 408576698