Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: chrome/common/extensions/extension.cc

Issue 1807001: Revert 45749 - (missing test fix)... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
===================================================================
--- chrome/common/extensions/extension.cc (revision 45750)
+++ chrome/common/extensions/extension.cc (working copy)
@@ -1447,26 +1447,16 @@
return true;
}
-GURL Extension::GalleryUrl() const {
- if (!update_url_.DomainIs("google.com"))
- return GURL();
-
- GURL url(std::string(extension_urls::kGalleryBrowsePrefix) +
- std::string("/detail/") + id_);
-
- return url;
-}
-
std::set<FilePath> Extension::GetBrowserImages() {
std::set<FilePath> image_paths;
- // Extension icons.
+ // extension icons
for (std::map<int, std::string>::iterator iter = icons_.begin();
iter != icons_.end(); ++iter) {
image_paths.insert(FilePath::FromWStringHack(UTF8ToWide(iter->second)));
}
- // Theme images.
+ // theme images
DictionaryValue* theme_images = GetThemeImages();
if (theme_images) {
for (DictionaryValue::key_iterator it = theme_images->begin_keys();
@@ -1477,7 +1467,7 @@
}
}
- // Page action icons.
+ // page action icons
if (page_action_.get()) {
std::vector<std::string>* icon_paths = page_action_->icon_paths();
for (std::vector<std::string>::iterator iter = icon_paths->begin();
@@ -1486,7 +1476,7 @@
}
}
- // Browser action icons.
+ // browser action icons
if (browser_action_.get()) {
std::vector<std::string>* icon_paths = browser_action_->icon_paths();
for (std::vector<std::string>::iterator iter = icon_paths->begin();
Property changes on: chrome\common\extensions\extension.cc
___________________________________________________________________
Deleted: svn:mergeinfo
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698