Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 1807001: Revert 45749 - (missing test fix)... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_ui.cc
===================================================================
--- chrome/browser/extensions/extensions_ui.cc (revision 45750)
+++ chrome/browser/extensions/extensions_ui.cc (working copy)
@@ -752,7 +752,7 @@
if (!extension->options_url().is_empty())
extension_data->SetString(L"options_url", extension->options_url().spec());
- // Add list of content_script detail DictionaryValues.
+ // Add list of content_script detail DictionaryValues
ListValue *content_script_list = new ListValue();
UserScriptList content_scripts = extension->content_scripts();
for (UserScriptList::const_iterator script = content_scripts.begin();
@@ -762,7 +762,7 @@
}
extension_data->Set(L"content_scripts", content_script_list);
- // Add permissions.
+ // Add permissions
ListValue *permission_list = new ListValue;
std::vector<URLPattern> permissions = extension->host_permissions();
for (std::vector<URLPattern>::iterator permission = permissions.begin();
@@ -778,7 +778,7 @@
iter != pages.end(); ++iter) {
DictionaryValue* view_value = new DictionaryValue;
view_value->SetString(L"path",
- iter->url.path().substr(1, std::string::npos)); // No leading slash.
+ iter->url.path().substr(1, std::string::npos)); // no leading slash
view_value->SetInteger(L"renderViewId", iter->render_view_id);
view_value->SetInteger(L"renderProcessId", iter->render_process_id);
views->Append(view_value);
@@ -786,7 +786,6 @@
extension_data->Set(L"views", views);
extension_data->SetBoolean(L"hasPopupAction",
extension->browser_action() || extension->page_action());
- extension_data->SetString(L"galleryUrl", extension->GalleryUrl().spec());
return extension_data;
}
« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/resources/extensions_ui.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698