Issue 18067: Fix issue 6264 with a test case....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18067: Fix issue 6264 with a test case.... (Closed)

Created:
11 years, 11 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson, Mads Ager (chromium), abarth-chromium

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix issue 6264 with a test case. The problem is that Disable/EnableAccessCheck on an object may chnage its constructor's behavior if object's map is the same as constructor's initial map. By copying maps, the constructor's initial map is not changed. Committed: http://code.google.com/p/v8/source/detail?r=1087

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -3 lines)			Patch
	M	src/runtime.cc	View		2 chunks	+19 lines, -3 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Larson

11 years, 11 months ago (2009-01-20 20:45:05 UTC) #3

On 2009/01/15 06:39:00, Mads Ager wrote:
> LGTM.  Good catch!

Can we get this ported to the 0.3 branch to make it easy to deliver to Chrome's
stable channel in a 154 build?

Expand Messages | Collapse Messages