Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 18067: Fix issue 6264 with a test case.... (Closed)

Created:
11 years, 11 months ago by Feng Qian
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 6264 with a test case. The problem is that Disable/EnableAccessCheck on an object may chnage its constructor's behavior if object's map is the same as constructor's initial map. By copying maps, the constructor's initial map is not changed. Committed: http://code.google.com/p/v8/source/detail?r=1087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M src/runtime.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Feng Qian
11 years, 11 months ago (2009-01-14 22:56:55 UTC) #1
Mads Ager (chromium)
LGTM. Good catch!
11 years, 11 months ago (2009-01-15 06:39:00 UTC) #2
Mark Larson
11 years, 11 months ago (2009-01-20 20:45:05 UTC) #3
On 2009/01/15 06:39:00, Mads Ager wrote:
> LGTM.  Good catch!

Can we get this ported to the 0.3 branch to make it easy to deliver to Chrome's
stable channel in a 154 build?

Powered by Google App Engine
This is Rietveld 408576698