Issue 1806003: Fix Bug in RingBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1806003: Fix Bug in RingBuffer (Closed)

Created:
10 years, 7 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix Bug in RingBuffer TEST=unit test BUG=42859 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46017

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -16 lines)			Patch
M	gpu/command_buffer/client/gles2_implementation.cc	View	4 chunks	+18 lines, -15 lines	1 comment	Download
M	gpu/command_buffer/client/ring_buffer.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/ring_buffer_test.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

10 years, 7 months ago (2010-04-29 22:26:51 UTC) #2

lgtm

http://codereview.chromium.org/1806003/diff/1/4
File gpu/command_buffer/client/gles2_implementation.cc (right):

http://codereview.chromium.org/1806003/diff/1/4#newcode647
gpu/command_buffer/client/gles2_implementation.cc:647: char* buffer =
transfer_buffer_.AllocTyped<char>(shader_id_size + length);
char -> int8

Expand Messages | Collapse Messages