Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1806002: Change the wording of the warning on the extension install dialog (Closed)

Created:
10 years, 8 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Change the wording of the warning on the extension install dialog from "needs access to" to "can access" per discusison on chromium-discuss. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
10 years, 8 months ago (2010-04-28 16:58:28 UTC) #1
Erik does not do reviews
10 years, 8 months ago (2010-04-28 16:59:35 UTC) #2
LGTM

On Wed, Apr 28, 2010 at 9:58 AM,  <aa@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Change the wording of the warning on the extension install
> dialog from "needs access to" to "can access" per discusison
> on chromium-discuss.
>
> Please review this at http://codereview.chromium.org/1806002/show
>
> Affected files:
>  M chrome/app/generated_resources.grd
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd
> b/chrome/app/generated_resources.grd
> index
>
ac21ee1b5f84d6094c412f08f7f91433f94afe86..401ddde3e0349c34114430564f050ea6eaca617d
> 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -3341,8 +3341,8 @@ each locale. -->
>       </message>
>
>       <!-- v2 extension install dialog strings -->
> -      <message name="IDS_EXTENSION_PROMPT2_WILL_HAVE_ACCESS_TO"
> desc="Second line in the content area of the extension installation
> prompt.">
> -        This extension needs access to:
> +      <message name="IDS_EXTENSION_PROMPT2_WILL_HAVE_ACCESS_TO"
> desc="Second line in the content area of the extension installation prompt.
> Note that the exact wording is important. This should mean that the
> extension _can_ access the listed privileges, but not necessarily that it
> will or needs to.">
> +        This extension can access:
>       </message>
>       <message name="IDS_EXTENSION_PROMPT2_WARNING_FULL_ACCESS"
> desc="Permission string for full access to the computer and all websites.">
>         All data on your computer and the websites you visit
>
>
>

Powered by Google App Engine
This is Rietveld 408576698