Issue 1805001: Valgrind: Widen a suppression....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1805001: Valgrind: Widen a suppression.... (Closed)

Created:
10 years, 8 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Valgrind: Widen a suppression. BUG=42590 TEST=Mac Valgrind gets greener. TBR=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45676

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/1805001/diff/1/2 File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/1805001/diff/1/2#newcode2640 tools/valgrind/memcheck/suppressions.txt:2640: ... Should we also remove the "..."?

10 years, 8 months ago (2010-04-27 17:23:04 UTC) #2

Lei Zhang

10 years, 8 months ago (2010-04-27 17:57:58 UTC) #3

http://codereview.chromium.org/1805001/diff/1/2
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/1805001/diff/1/2#newcode2640
tools/valgrind/memcheck/suppressions.txt:2640: ...
On 2010/04/27 17:23:04, wtc wrote:
> Should we also remove the "..."?

I should have. It still works though.

Expand Messages | Collapse Messages