The first step towards Turkish spell-checker....

The first step towards Turkish spell-checker.This is a set of fixes for supporting the Turkish dictionary provided by the tr-spell project (*1).As I wrote in http://crbug.com/4782, this issue consists of three issues: one is against our convert_dict tool, and two are against our hunspell client.(*1) http://code.google.com/p/tr-spell/Unfortunately, the BDIC file converted from this Turkish dictionary is huge (7.1MB) because the dictionary has a lot of affix rules (> 18,000) and the most of the BDIC file is occupied by "AF" lines.

BUG=4782
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9122

[brettw, 2009-01-14 16:52:06]

LGTM. Thanks Hironiro, this looks great. I just have a few comment suggestions,
can you fix them before checking in?

http://codereview.chromium.org/18041/diff/14/16
File chrome/third_party/hunspell/src/hunspell/hashmgr.cxx (right):

http://codereview.chromium.org/18041/diff/14/16#newcode563
Line 563: // IGNORE line here. The rest of the commands will be read by the
affix
Can you reword this comment a bit now that you've added a new line? It shouldn't
say "we only care about the ignore line" anymore. How about "We care about FLAG
line becuase the AF lines depend on this value, and the INORE line. The rest of
the commands will be read by the affix manager."

Then you don't need your new comment lines.

http://codereview.chromium.org/18041/diff/14/15
File chrome/third_party/hunspell/src/hunspell/htypes.hxx (right):

http://codereview.chromium.org/18041/diff/14/15#newcode5
Line 5: #define MAXDELEN    (8192 * 2)
Can you comment why you changed this?

[Hironori Bono, 2009-01-15 10:00:38]

Thank you for your review and comments.
Your typo is not a problem at all because even I often mistype my name. :)

http://codereview.chromium.org/18041/diff/14/16
File chrome/third_party/hunspell/src/hunspell/hashmgr.cxx (right):

http://codereview.chromium.org/18041/diff/14/16#newcode563
Line 563: // IGNORE line here. The rest of the commands will be read by the
affix
Done. Thank you for your suggestion.

http://codereview.chromium.org/18041/diff/14/15
File chrome/third_party/hunspell/src/hunspell/htypes.hxx (right):

http://codereview.chromium.org/18041/diff/14/15#newcode5
Line 5: #define MAXDELEN    (8192 * 2)
Done. I have added a comment describe we need to increase this value to handle
long AF lines included in Turkish BDICs.