Issue 1803004: licenses: don't double-include NSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1803004: licenses: don't double-include NSS (Closed)

Created:
10 years, 8 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, arv (Not doing code reviews), pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

licenses: don't double-include NSS in about:credits Just manually blacklist one of the copies. We already do this for some other modules. BUG=42663 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45765

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -45 lines)			Patch
	M	chrome/browser/resources/about_credits.html	View		1 chunk	+0 lines, -45 lines	0 comments	Download
	M	tools/licenses.py	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 8 months ago (2010-04-27 20:58:31 UTC) #2

LGTM.  Thanks!

http://codereview.chromium.org/1803004/diff/1/3
File tools/licenses.py (right):

http://codereview.chromium.org/1803004/diff/1/3#newcode46
tools/licenses.py:46: # Same module occurs in base/ and in net/, so skip one of
them.
Nit: add a blank line before this comment to follow the
existing style.

Expand Messages | Collapse Messages