Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1803003: Initial version of hermetic CygWin script. (Closed)

Created:
10 years, 8 months ago by khimg
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Initial version of hermetic CygWin script. Committed: http://code.google.com/p/nativeclient/source/detail?r=2159

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 16

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2110 lines, -1 line) Patch
M DEPS View 2 chunks +4 lines, -1 line 0 comments Download
A tools/hermetic_cygwin/MkLink/MkLink.c View 1 2 3 4 1 chunk +415 lines, -0 lines 1 comment Download
A tools/hermetic_cygwin/MkLink/MkLink.sln View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A tools/hermetic_cygwin/MkLink/MkLink.vcproj View 1 chunk +484 lines, -0 lines 0 comments Download
A tools/hermetic_cygwin/MkLink/Release Unicode/MkLink.dll View Binary file 0 comments Download
A tools/hermetic_cygwin/MkLink/Release/MkLink.dll View Binary file 0 comments Download
A tools/hermetic_cygwin/make_hermetic_cygwin.conf View 1 2 Binary file 0 comments Download
A tools/hermetic_cygwin/make_hermetic_cygwin.sh View 1 chunk +206 lines, -0 lines 1 comment Download
A tools/hermetic_cygwin/make_installer.inc View 1 2 3 1 chunk +975 lines, -0 lines 0 comments Download
A tools/hermetic_cygwin/setup/Cygwin.ico View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
khimg
10 years, 8 months ago (2010-04-27 19:24:17 UTC) #1
bradn
Should the .conf file be binary? http://codereview.chromium.org/1803003/diff/3002/14 File tools/hermetic_cygwin/MkLink/MkLink.c (right): http://codereview.chromium.org/1803003/diff/3002/14#newcode34 tools/hermetic_cygwin/MkLink/MkLink.c:34: #include <commctrl.h> Sort? ...
10 years, 8 months ago (2010-04-28 00:35:56 UTC) #2
khimg
http://codereview.chromium.org/1803003/diff/3002/14 File tools/hermetic_cygwin/MkLink/MkLink.c (right): http://codereview.chromium.org/1803003/diff/3002/14#newcode34 tools/hermetic_cygwin/MkLink/MkLink.c:34: #include <commctrl.h> On 2010/04/28 00:35:56, bradn wrote: > Sort? ...
10 years, 8 months ago (2010-04-28 07:44:08 UTC) #3
dpolukhin
10 years, 8 months ago (2010-04-28 13:16:08 UTC) #4
http://codereview.chromium.org/1803003/diff/1009/12005
File tools/hermetic_cygwin/MkLink/MkLink.c (right):

http://codereview.chromium.org/1803003/diff/1009/12005#newcode38
tools/hermetic_cygwin/MkLink/MkLink.c:38: #define _tcscat wcscat
It is standard defines from tchar.h actually. If you need to use kernel
functions instead of CRT use them explicit it is better.

http://codereview.chromium.org/1803003/diff/1009/12005#newcode122
tools/hermetic_cygwin/MkLink/MkLink.c:122: fCreateHardLink =
GetProcAddress(hKernel32, CreateHardLink);
It is available starting from Windows 2000 so there is no sense to make late
binding.

http://codereview.chromium.org/1803003/diff/15001/16005#newcode92
tools/hermetic_cygwin/MkLink/MkLink.c:92: 
As far as I understand maximum path of 32,767 characters approx. Your code has
no check for buffer overflow... It can be especially dangerous for installer
that may overwrite/delete some user files.

http://codereview.chromium.org/1803003/diff/15001/16008
File tools/hermetic_cygwin/make_hermetic_cygwin.sh (right):

http://codereview.chromium.org/1803003/diff/15001/16008#newcode72
tools/hermetic_cygwin/make_hermetic_cygwin.sh:72: if ((need_restart)) ; then
Add comment that it may happen only in Cygwin.

Powered by Google App Engine
This is Rietveld 408576698