Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1803001: Fix second-profile dir so that it's a sibling of the first; eliminate a FromWStringHack. (Closed)

Created:
10 years, 8 months ago by ncarter (slow)
Modified:
9 years, 7 months ago
Reviewers:
Dan Tasse
CC:
chromium-reviews, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Fix second-profile dir so that it's a sibling of the first; eliminate a FromWStringHack. TEST=sync_integration_tests fail less. BUG=42642 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45839

Patch Set 1 #

Patch Set 2 : Formatting fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chrome/test/live_sync/bookmark_model_verifier.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/live_sync_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/single_client_live_preferences_sync_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/live_sync/two_client_live_preferences_sync_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ncarter (slow)
10 years, 8 months ago (2010-04-27 20:32:29 UTC) #1
Dan Tasse
10 years, 8 months ago (2010-04-27 20:35:54 UTC) #2
On 2010/04/27 20:32:29, nick wrote:
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698