POSIX: catch more crash-indicating signals for in-process crash dumping.

base/process_util_posix.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/resource.h>
@@ skipping 84 matching lines @@
     }
   }
 
   if (success)
     *success = (ret_pid != -1);
 
   return status;
 }
 
 void StackDumpSignalHandler(int signal) {
+  LOG(ERROR) << "Received signal " << signal;
   StackTrace().PrintBacktrace();
   _exit(1);
 }
 
 }  // anonymous namespace
 
 ProcessId GetCurrentProcId() {
   return getpid();
 }
 
@@ skipping 470 matching lines @@
 bool EnableInProcessStackDumping() {
   // When running in an application, our code typically expects SIGPIPE
   // to be ignored.  Therefore, when testing that same code, it should run
   // with SIGPIPE ignored as well.
   struct sigaction action;
   action.sa_handler = SIG_IGN;
   action.sa_flags = 0;
   sigemptyset(&action.sa_mask);
   bool success = (sigaction(SIGPIPE, &action, NULL) == 0);
 
-  // TODO(phajdan.jr): Catch other crashy signals, like SIGABRT.
+  success &= (signal(SIGILL, &StackDumpSignalHandler) != SIG_ERR);
+  success &= (signal(SIGABRT, &StackDumpSignalHandler) != SIG_ERR);
+  success &= (signal(SIGFPE, &StackDumpSignalHandler) != SIG_ERR);
+  success &= (signal(SIGBUS, &StackDumpSignalHandler) != SIG_ERR);
   success &= (signal(SIGSEGV, &StackDumpSignalHandler) != SIG_ERR);
-  success &= (signal(SIGILL, &StackDumpSignalHandler) != SIG_ERR);
-  success &= (signal(SIGBUS, &StackDumpSignalHandler) != SIG_ERR);
-  success &= (signal(SIGFPE, &StackDumpSignalHandler) != SIG_ERR);
+  success &= (signal(SIGSYS, &StackDumpSignalHandler) != SIG_ERR);
+
   return success;
 }
 
 void AttachToConsole() {
   // On POSIX, there nothing to do AFAIK. Maybe create a new console if none
   // exist?
 }
 
 void RaiseProcessToHighPriority() {
   // On POSIX, we don't actually do anything here.  We could try to nice() or
@@ skipping 263 matching lines @@
                       const ProcessFilter* filter) {
   bool exited_cleanly =
       WaitForProcessesToExit(executable_name, wait_milliseconds,
                              filter);
   if (!exited_cleanly)
     KillProcesses(executable_name, exit_code, filter);
   return exited_cleanly;
 }
 
 }  // namespace base