Issue 1801006: In the sync integration tests for preferences, don't assume a specific

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1801006: In the sync integration tests for preferences, don't assume a specific (Closed)

Created:
10 years, 8 months ago by albertb

Modified:
9 years, 3 months ago

Reviewers:
Raghu Simha, ncarter (slow)

CC:
chromium-reviews, Paweł Hajdan Jr., tim (not reviewing), idana

Visibility:
Public.

Description

In the sync integration tests for preferences, don't assume a specific initial value for kHomePageIsNewTabPage. BUG=42669 TEST=TwoClientLivePreferencesSyncTest.Sanity Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45979

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	chrome/test/live_sync/two_client_live_preferences_sync_test.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

On 2010/04/29 18:50:30, albertb wrote: > Ping? LGTM. Raghu should have a look too.

10 years, 7 months ago (2010-04-29 19:59:26 UTC) #3

Raghu Simha

10 years, 7 months ago (2010-04-29 20:22:21 UTC) #4

On 2010/04/29 19:59:26, nick wrote:
> On 2010/04/29 18:50:30, albertb wrote:
> > Ping?
> 
> LGTM.  Raghu should have a look too.

LGTM. I've also verified that the test now passes on windows and does not make
any assumptions about the default value of kHomePageIsNewTabPage.

Expand Messages | Collapse Messages