Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/x64/ic-x64.cc

Issue 180040: X64: Fix bug introduced in revision 2779 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
842 Label miss, probe, global; 842 Label miss, probe, global;
843 843
844 __ movq(rax, Operand(rsp, kPointerSize)); 844 __ movq(rax, Operand(rsp, kPointerSize));
845 845
846 // Check that the receiver isn't a smi. 846 // Check that the receiver isn't a smi.
847 __ testl(rax, Immediate(kSmiTagMask)); 847 __ testl(rax, Immediate(kSmiTagMask));
848 __ j(zero, &miss); 848 __ j(zero, &miss);
849 849
850 // Check that the receiver is a valid JS object. 850 // Check that the receiver is a valid JS object.
851 __ CmpObjectType(rax, FIRST_JS_OBJECT_TYPE, rbx); 851 __ CmpObjectType(rax, FIRST_JS_OBJECT_TYPE, rbx);
852 __ j(less, &miss); 852 __ j(below, &miss);
853 853
854 // If this assert fails, we have to check upper bound too. 854 // If this assert fails, we have to check upper bound too.
855 ASSERT(LAST_TYPE == JS_FUNCTION_TYPE); 855 ASSERT(LAST_TYPE == JS_FUNCTION_TYPE);
856 856
857 // Check for access to global object (unlikely). 857 // Check for access to global object (unlikely).
858 __ CmpInstanceType(rbx, JS_GLOBAL_PROXY_TYPE); 858 __ CmpInstanceType(rbx, JS_GLOBAL_PROXY_TYPE);
859 __ j(equal, &global); 859 __ j(equal, &global);
860 860
861 // Check for non-global object that requires access check. 861 // Check for non-global object that requires access check.
862 __ testl(FieldOperand(rbx, Map::kBitFieldOffset), 862 __ testl(FieldOperand(rbx, Map::kBitFieldOffset),
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 979
980 // Cache miss: Jump to runtime. 980 // Cache miss: Jump to runtime.
981 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss))); 981 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
982 } 982 }
983 983
984 984
985 #undef __ 985 #undef __
986 986
987 987
988 } } // namespace v8::internal 988 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698