Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 180040: X64: Fix bug introduced in revision 2779 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/ic-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 __ mov(ecx, Operand(esp, (argc + 2) * kPointerSize)); 597 __ mov(ecx, Operand(esp, (argc + 2) * kPointerSize));
598 598
599 // Check that the receiver isn't a smi. 599 // Check that the receiver isn't a smi.
600 __ test(edx, Immediate(kSmiTagMask)); 600 __ test(edx, Immediate(kSmiTagMask));
601 __ j(zero, &miss, not_taken); 601 __ j(zero, &miss, not_taken);
602 602
603 // Check that the receiver is a valid JS object. 603 // Check that the receiver is a valid JS object.
604 __ mov(ebx, FieldOperand(edx, HeapObject::kMapOffset)); 604 __ mov(ebx, FieldOperand(edx, HeapObject::kMapOffset));
605 __ movzx_b(eax, FieldOperand(ebx, Map::kInstanceTypeOffset)); 605 __ movzx_b(eax, FieldOperand(ebx, Map::kInstanceTypeOffset));
606 __ cmp(eax, FIRST_JS_OBJECT_TYPE); 606 __ cmp(eax, FIRST_JS_OBJECT_TYPE);
607 __ j(less, &miss, not_taken); 607 __ j(below, &miss, not_taken);
608 608
609 // If this assert fails, we have to check upper bound too. 609 // If this assert fails, we have to check upper bound too.
610 ASSERT(LAST_TYPE == JS_FUNCTION_TYPE); 610 ASSERT(LAST_TYPE == JS_FUNCTION_TYPE);
611 611
612 // Check for access to global object. 612 // Check for access to global object.
613 __ cmp(eax, JS_GLOBAL_OBJECT_TYPE); 613 __ cmp(eax, JS_GLOBAL_OBJECT_TYPE);
614 __ j(equal, &global_object); 614 __ j(equal, &global_object);
615 __ cmp(eax, JS_BUILTINS_OBJECT_TYPE); 615 __ cmp(eax, JS_BUILTINS_OBJECT_TYPE);
616 __ j(not_equal, &non_global_object); 616 __ j(not_equal, &non_global_object);
617 617
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 1032
1033 // Do tail-call to runtime routine. 1033 // Do tail-call to runtime routine.
1034 __ TailCallRuntime( 1034 __ TailCallRuntime(
1035 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3); 1035 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3);
1036 } 1036 }
1037 1037
1038 #undef __ 1038 #undef __
1039 1039
1040 1040
1041 } } // namespace v8::internal 1041 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698