Issue 180026: Linux: use mmap fonts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180026: Linux: use mmap fonts. (Closed)

Created:
11 years, 3 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: use mmap fonts. FreeType makes a lot of seek calls when we give it fonts as a stream. To avoid the seeks (which hurt the SUID sandbox), we mmap the fonts. Will need to pay attention to the perf bots after this lands.

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -23 lines)			Patch
	M	skia/ext/SkFontHost_fontconfig.cpp	View		3 chunks	+36 lines, -23 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 3 months ago (2009-08-28 20:11:29 UTC) #2

LGTM

http://codereview.chromium.org/180026/diff/1/2
File skia/ext/SkFontHost_fontconfig.cpp (right):

http://codereview.chromium.org/180026/diff/1/2#newcode32
Line 32: #include <sys/mman.h>
Nit: Sort these?

Expand Messages | Collapse Messages