Issue 180022: Add four new suppressions, widen one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180022: Add four new suppressions, widen one. (Closed)

Created:
11 years, 3 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Pam (message me for reviews), dank, the_wrong_timurrrr, stuartmorgan

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress a leak in ps (!), and fix a typo that disabled a suppression for an expected leak in CheckOpString Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24787

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -4 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View	1 2	3 chunks	+34 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

11 years, 3 months ago (2009-08-28 17:58:14 UTC) #2

LGTM

http://codereview.chromium.org/180022/diff/1/3
File tools/valgrind/memcheck/suppressions_mac.txt (right):

http://codereview.chromium.org/180022/diff/1/3#newcode533
Line 533: fun:_ZN7WebCore4Node16querySelectorAllERKNS_6StringERi
Maybe we should just widen the existing one to:
Memcheck:Free
   fun:_ZdlPv
  
fun:_ZN7WebCore15CSSSelectorList19adoptSelectorVectorERN3WTF6VectorIPNS_11CSSSelectorELm0EEE
   ...
   fun:_Z10cssyyparsePv
rather than adding a new one?

Expand Messages | Collapse Messages