[Mac] Handle backspacing out of keyword search.

[Mac] Handle backspacing out of keyword search.

When the user hits backspace with the caret on the LHS in a keyword
search, should exit keyword search.

[Apple keyboards may label what I'm calling "backspace" as "delete".
The wide key above |\ key.]

http://crbug.com/20286
TEST=Type www.google.com, then tab to enter keyword search.  Type some
text.  Select-all and hit backspace, should stay in keyword mode.
Type some text, backspace should work as normal.  Type some text,
position caret at LHS, backspace should take you out of keyword mode.

[rohitrao (ping after 24h), 2009-08-28 17:36:29]

LGTM, with nits.

What does Windows do when you press backspace with the cursor all the way to the
left?  Dropping out of tab to search mode feels a bit weird to me, but maybe
that's the best thing to do...

http://codereview.chromium.org/180009/diff/1/3
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/180009/diff/1/3#newcode633
Line 633: const NSRange selection(GetSelectedRange());
You have this same line written as "const NSRange selectedRange =
GetSelectedRange();" in the function above.  Can you match for consistency's
sake?

[Scott Hess - ex-Googler, 2009-08-28 17:52:02]

On 2009/08/28 17:36:29, rohitrao wrote:
> What does Windows do when you press backspace with the cursor all the way to
the
> left?  Dropping out of tab to search mode feels a bit weird to me, but maybe
> that's the best thing to do...

That sure is weird.  I modeled on gtk implementation, but Windows does the same.
 Kinda useless because you can't do something obvious like hit tab to get back
to where you where.

http://codereview.chromium.org/180009/diff/1/3
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/180009/diff/1/3#newcode633
Line 633: const NSRange selection(GetSelectedRange());
On 2009/08/28 17:36:30, rohitrao wrote:
> You have this same line written as "const NSRange selectedRange =
> GetSelectedRange();" in the function above.  Can you match for consistency's
> sake?

Done.