Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1799002: Fix the toolkit_views gyp variable define mania. (Closed)

Created:
10 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the toolkit_views gyp variable define mania. This makes it so toolkit_views==1 is always true for views builds, either on Windows or ChromeOS. Three levels of nesting are needed for this chained conditional: 1) Set the default value of ChromeOS. 2) Depending on ChromeOS value, set the default value of toolkit_views. 3) Depending on toolkit_views value, set the rest of the build variables. This should have no affect on the build, but will allow subsequent cleanup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45639

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : build fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M build/common.gypi View 2 chunks +19 lines, -7 lines 1 comment Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
This makes it so toolkit_views==1 is always true for views builds throughout gyp. This will ...
10 years, 8 months ago (2010-04-26 22:05:56 UTC) #1
Evan Martin
http://codereview.chromium.org/1799002/diff/4001/5001 File build/common.gypi (right): http://codereview.chromium.org/1799002/diff/4001/5001#newcode53 build/common.gypi:53: # We set the initial value at this level ...
10 years, 8 months ago (2010-04-26 22:06:59 UTC) #2
sky
10 years, 8 months ago (2010-04-26 22:35:55 UTC) #3
OK

Powered by Google App Engine
This is Rietveld 408576698