Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 1798006: Thanks to gman, fixed o3d.webgl.createClient and o3d-webgl Client to handle... (Closed)

Created:
10 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
greggman
CC:
o3d-review_googlegroups.com, petersont
Visibility:
Public.

Description

Thanks to gman, fixed o3d.webgl.createClient and o3d-webgl Client to handle resizing of div containing O3D element. Added simpleviewer sample. BUG=none TEST=ran simpleviewer sample Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -4 lines) Patch
A samples/o3d-webgl-samples/simpleviewer/simpleviewer.html View 1 chunk +372 lines, -0 lines 0 comments Download
M samples/o3d-webgl/client.js View 3 chunks +10 lines, -2 lines 0 comments Download
M samples/o3djs/webgl.js View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
10 years, 8 months ago (2010-04-28 00:18:43 UTC) #1
greggman
10 years, 8 months ago (2010-04-28 01:27:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698