Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1794007: Harden build_image to not lose loopback devices. (Closed)

Created:
10 years, 7 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//chromeos
Visibility:
Public.

Description

Harden build_image to not lose loopback devices.

Patch Set 1 #

Patch Set 2 : Added delete_prompt logic #

Patch Set 3 : Small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/scripts/build_image View 1 2 4 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sosa
TEST: Running build_image 6x and ctrl+c'ing at random points during executation, checking losetup -a and ...
10 years, 7 months ago (2010-04-29 18:02:12 UTC) #1
Bill Richardson
LGTM.
10 years, 7 months ago (2010-04-29 18:22:10 UTC) #2
sosa
PTAL, I've added some logic to prompt to delete the output dir if an error ...
10 years, 7 months ago (2010-04-29 18:22:38 UTC) #3
Bill Richardson
10 years, 7 months ago (2010-04-29 19:32:52 UTC) #4 
still LGTM

Powered by Google App Engine
This is Rietveld 408576698