Issue 1794003: Views: Disable a failing test on the Linux views bot....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1794003: Views: Disable a failing test on the Linux views bot.... (Closed)

Created:
10 years, 8 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Views: Disable a failing test on the Linux views bot. BUG=42514 TEST=Bot goes green. TBR=oshima Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45662

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/views/tabs/tab_dragging_test.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

10 years, 8 months ago (2010-04-27 07:44:18 UTC) #2

lgtm

On Mon, Apr 26, 2010 at 7:11 PM, <thestig@chromium.org> wrote:

> Reviewers: oshima,
>
> Message:
> Greening up the tree, hopefully.
>
> Description:
> Views: Disable a failing test on the Linux views bot.
>
> BUG=42514
> TEST=Bot goes green.
> TBR=oshima
>
> Please review this at http://codereview.chromium.org/1794003/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/views/tabs/tab_dragging_test.cc
>
>
> Index: chrome/browser/views/tabs/tab_dragging_test.cc
> ===================================================================
> --- chrome/browser/views/tabs/tab_dragging_test.cc      (revision 45661)
> +++ chrome/browser/views/tabs/tab_dragging_test.cc      (working copy)
> @@ -21,14 +21,16 @@
>  #if defined(OS_CHROMEOS)
>  // Disabled, see http://crbug.com/40043.
>  #define MAYBE_Tab2OutOfTabStrip DISABLED_Tab2OutOfTabStrip
> -#define MAYBE_Tab1Tab3Escape DISABLED_Tab1Tab3Escape
> -
>  #else
>  #define MAYBE_Tab2OutOfTabStrip Tab2OutOfTabStrip
> +#endif
>
> +#if defined(TOOLKIT_VIEWS) && defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +// Disabled on Toolkit views bot. See http://crbug.com/42614
> +#define MAYBE_Tab1Tab3Escape DISABLED_Tab1Tab3Escape
> +#else
>  // Flaky, see http://crbug.com/21092.
>  #define MAYBE_Tab1Tab3Escape FLAKY_Tab1Tab3Escape
> -
>  #endif
>
>
>
>
>

Expand Messages | Collapse Messages