Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 1792006: Link the name of the extension on the management page to the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_context_menu_model.cc
===================================================================
--- chrome/browser/extensions/extension_context_menu_model.cc (revision 45664)
+++ chrome/browser/extensions/extension_context_menu_model.cc (working copy)
@@ -74,7 +74,7 @@
// hosting the extension. For other 3rd party extensions we don't have a
// homepage url, so we just disable this menu item on those cases, at least
// for now.
- return extension_->update_url().DomainIs("google.com");
+ return extension_->GalleryUrl().is_valid();
} else if (command_id == INSPECT_POPUP) {
TabContents* contents = browser_->GetSelectedTabContents();
if (!contents)
@@ -93,9 +93,8 @@
void ExtensionContextMenuModel::ExecuteCommand(int command_id) {
switch (command_id) {
case NAME: {
- GURL url(std::string(extension_urls::kGalleryBrowsePrefix) +
- std::string("/detail/") + extension_->id());
- browser_->OpenURL(url, GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
+ browser_->OpenURL(extension_->GalleryUrl(), GURL(),
+ NEW_FOREGROUND_TAB, PageTransition::LINK);
break;
}
case CONFIGURE:
« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698