Issue 179062: Fix the handling of termination exceptions thrown when creating error...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179062: Fix the handling of termination exceptions thrown when creating error... (Closed)

Created:
11 years, 3 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix the handling of termination exceptions thrown when creating error objects in the runtime system. Committed: http://code.google.com/p/v8/source/detail?r=2796

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -20 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/messages.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/top.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/top.cc	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	test/cctest/test-thread-termination.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-01 13:53:38 UTC) #2

LGTM

Looks as if getting rid of force_clear_catchable is a good thing.