Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6155)

Unified Diff: chrome/browser/blocked_popup_container.h

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/blocked_popup_container.h
diff --git a/chrome/browser/blocked_popup_container.h b/chrome/browser/blocked_popup_container.h
index 4d89a3f449b94384e5d6a62b1ebec49e81382aa1..d7e5d0ef0b4ce34f7da7c49b1266d62111194fb8 100644
--- a/chrome/browser/blocked_popup_container.h
+++ b/chrome/browser/blocked_popup_container.h
@@ -52,8 +52,6 @@ class BlockedPopupContainerView {
// Called by the BlockedPopupContainer that owns us. Destroys the view or
// starts a delayed Task to destroy the View at some later time.
virtual void Destroy() = 0;
- protected:
- ~BlockedPopupContainerView() {}
};
// Takes ownership of TabContents that are unrequested popup windows and
@@ -148,7 +146,7 @@ class BlockedPopupContainer : public TabContentsDelegate,
// Ignored; BlockedPopupContainer doesn't display a throbber.
virtual void NavigationStateChanged(const TabContents* source,
- unsigned changed_flags) {}
+ unsigned changed_flags) { }
// Forwards AddNewContents to our |owner_|.
virtual void AddNewContents(TabContents* source,
@@ -158,10 +156,10 @@ class BlockedPopupContainer : public TabContentsDelegate,
bool user_gesture);
// Ignore activation requests from the TabContents we're blocking.
- virtual void ActivateContents(TabContents* contents) {}
+ virtual void ActivateContents(TabContents* contents) { }
// Ignored; BlockedPopupContainer doesn't display a throbber.
- virtual void LoadingStateChanged(TabContents* source) {}
+ virtual void LoadingStateChanged(TabContents* source) { }
// Removes |source| from our internal list of blocked popups.
virtual void CloseContents(TabContents* source);
@@ -176,13 +174,13 @@ class BlockedPopupContainer : public TabContentsDelegate,
virtual TabContents* GetConstrainingContents(TabContents* source);
// Ignored; BlockedPopupContainer doesn't display a toolbar.
- virtual void ToolbarSizeChanged(TabContents* source, bool is_animating) {}
+ virtual void ToolbarSizeChanged(TabContents* source, bool is_animating) { }
// Ignored; BlockedPopupContainer doesn't display a bookmarking star.
- virtual void URLStarredChanged(TabContents* source, bool starred) {}
+ virtual void URLStarredChanged(TabContents* source, bool starred) { }
// Ignored; BlockedPopupContainer doesn't display a URL bar.
- virtual void UpdateTargetURL(TabContents* source, const GURL& url) {}
+ virtual void UpdateTargetURL(TabContents* source, const GURL& url) { }
// A number larger than the internal popup count on the Renderer; meant for
// preventing a compromised renderer from exhausting GDI memory by spawning
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/bookmarks/bookmark_model_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698