base/third_party/dmg_fp/dtoa.cc - Issue 179028: Revert "Fix a ton of compiler warnings."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/dmg_fp/dtoa.cc

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/third_party/dmg_fp/dtoa.cc

diff --git a/base/third_party/dmg_fp/dtoa.cc b/base/third_party/dmg_fp/dtoa.cc

index ffbc088fc9d6c5965ca6bb9a3147ead38e7327d1..c1bc47629c9654aa1acfc23e2c15d7cd589b1cb4 100644

--- a/base/third_party/dmg_fp/dtoa.cc

+++ b/base/third_party/dmg_fp/dtoa.cc

@@ -1559,7 +1559,7 @@ hexnan

CONST char *s;

int c1, havedig, udx0, xshift;

- if (!hexdig[static_cast<int>('0')])

+ if (!hexdig['0'])

hexdig_init();

x[0] = x[1] = 0;

havedig = xshift = 0;

@@ -3283,7 +3283,7 @@ strtod

#ifdef Avoid_Underflow

if (bc.scale && y <= 2*P*Exp_msk1) {

if (aadj <= 0x7fffffff) {

- if ((z = static_cast<ULong>(aadj)) <= 0)

+ if ((z = aadj) <= 0)

z = 1;

aadj = z;

aadj1 = bc.dsign ? aadj : -aadj;

@@ -3837,7 +3837,7 @@ dtoa

dval(&eps) = 0.5/tens[ilim-1] - dval(&eps);

for(i = 0;;) {

- L = static_cast<long>(dval(&u));

+ L = dval(&u);

dval(&u) -= L;

*s++ = '0' + (int)L;

if (dval(&u) < dval(&eps))

« no previous file with comments | « base/third_party/dmg_fp/README.chromium ('k') | base/time.h » ('j') | no next file with comments »