Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: net/ftp/ftp_auth_cache_unittest.cc

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ssl_client_auth_cache_unittest.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_auth_cache_unittest.cc
diff --git a/net/ftp/ftp_auth_cache_unittest.cc b/net/ftp/ftp_auth_cache_unittest.cc
index a4d8ef4f7a9fd26e123321e4a27214e49d257d40..f74762b8903d87654e30266255e39e5c08ee29b0 100644
--- a/net/ftp/ftp_auth_cache_unittest.cc
+++ b/net/ftp/ftp_auth_cache_unittest.cc
@@ -24,7 +24,7 @@ TEST(FtpAuthCacheTest, LookupAddRemove) {
scoped_refptr<AuthData> data3(new AuthData());
// Lookup non-existent entry.
- EXPECT_TRUE(NULL == cache.Lookup(origin1));
+ EXPECT_EQ(NULL, cache.Lookup(origin1));
// Add entry for origin1.
cache.Add(origin1, data1.get());
@@ -42,12 +42,12 @@ TEST(FtpAuthCacheTest, LookupAddRemove) {
// Remove entry of origin1.
cache.Remove(origin1);
- EXPECT_TRUE(NULL == cache.Lookup(origin1));
+ EXPECT_EQ(NULL, cache.Lookup(origin1));
EXPECT_EQ(data2.get(), cache.Lookup(origin2));
// Remove non-existent entry
cache.Remove(origin1);
- EXPECT_TRUE(NULL == cache.Lookup(origin1));
+ EXPECT_EQ(NULL, cache.Lookup(origin1));
EXPECT_EQ(data2.get(), cache.Lookup(origin2));
}
@@ -93,7 +93,7 @@ TEST(FtpAuthCacheTest, NormalizedKey) {
// Remove
cache.Remove(GURL("ftp://HOsT"));
- EXPECT_TRUE(NULL == cache.Lookup(GURL("ftp://host")));
+ EXPECT_EQ(NULL, cache.Lookup(GURL("ftp://host")));
}
TEST(FtpAuthCacheTest, EvictOldEntries) {
@@ -112,7 +112,7 @@ TEST(FtpAuthCacheTest, EvictOldEntries) {
// Adding one entry should cause eviction of the first entry.
cache.Add(GURL("ftp://last_host"), auth_data.get());
- EXPECT_TRUE(NULL == cache.Lookup(GURL("ftp://host0")));
+ EXPECT_EQ(NULL, cache.Lookup(GURL("ftp://host0")));
// Remaining entries should not get evicted.
for (size_t i = 1; i < FtpAuthCache::kMaxEntries; i++) {
« no previous file with comments | « net/base/ssl_client_auth_cache_unittest.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698