chrome/common/extensions/extension_unittest.cc - Issue 179028: Revert "Fix a ton of compiler warnings."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_unittest.cc

diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc

index 09b320be9918ead97b0eb93755d4eb4209effa6d..fb40330e0f93ee172b7b698a761c29c111f2d55f 100644

--- a/chrome/common/extensions/extension_unittest.cc

+++ b/chrome/common/extensions/extension_unittest.cc

@@ -293,7 +293,7 @@ TEST(ExtensionTest, LoadPageActionHelper) {

DictionaryValue input;

// First try with an empty dictionary. We should get nothing back.

- ASSERT_TRUE(NULL == extension.LoadPageActionHelper(&input, 0, &error_msg));

+ ASSERT_EQ(NULL, extension.LoadPageActionHelper(&input, 0, &error_msg));

ASSERT_STRNE("", error_msg.c_str());

error_msg = "";

« no previous file with comments | « chrome/common/child_process_host.cc ('k') | chrome/common/gtk_tree.h » ('j') | no next file with comments »