Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Side by Side Diff: chrome/common/child_process_host.cc

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/child_process_host.h" 5 #include "chrome/common/child_process_host.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 bool did_crash = base::DidProcessCrash(NULL, handle()); 199 bool did_crash = base::DidProcessCrash(NULL, handle());
200 if (did_crash) { 200 if (did_crash) {
201 // Report that this child process crashed. 201 // Report that this child process crashed.
202 Notify(NotificationType::CHILD_PROCESS_CRASHED); 202 Notify(NotificationType::CHILD_PROCESS_CRASHED);
203 } 203 }
204 // Notify in the main loop of the disconnection. 204 // Notify in the main loop of the disconnection.
205 Notify(NotificationType::CHILD_PROCESS_HOST_DISCONNECTED); 205 Notify(NotificationType::CHILD_PROCESS_HOST_DISCONNECTED);
206 206
207 // On POSIX, once we've called DidProcessCrash, handle() is no longer 207 // On POSIX, once we've called DidProcessCrash, handle() is no longer
208 // valid. Ensure the destructor doesn't try to use it. 208 // valid. Ensure the destructor doesn't try to use it.
209 set_handle(0); 209 set_handle(NULL);
210 210
211 delete this; 211 delete this;
212 } 212 }
213 213
214 ChildProcessHost::ListenerHook::ListenerHook(ChildProcessHost* host) 214 ChildProcessHost::ListenerHook::ListenerHook(ChildProcessHost* host)
215 : host_(host) { 215 : host_(host) {
216 } 216 }
217 217
218 void ChildProcessHost::ListenerHook::OnMessageReceived( 218 void ChildProcessHost::ListenerHook::OnMessageReceived(
219 const IPC::Message& msg) { 219 const IPC::Message& msg) {
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 299
300 return *iterator_; 300 return *iterator_;
301 } while (true); 301 } while (true);
302 302
303 return NULL; 303 return NULL;
304 } 304 }
305 305
306 bool ChildProcessHost::Iterator::Done() { 306 bool ChildProcessHost::Iterator::Done() {
307 return iterator_ == Singleton<ChildProcessList>::get()->end(); 307 return iterator_ == Singleton<ChildProcessList>::get()->end();
308 } 308 }
OLDNEW
« no previous file with comments | « chrome/browser/webdata/web_data_service.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698