Revert "Fix a ton of compiler warnings."

chrome/browser/renderer_host/render_view_host_delegate.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 118 matching lines @@
     // event (used for keyboard shortcuts).
     virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event) = 0;
 
     // Notifications about mouse events in this view.  This is useful for
     // implementing global 'on hover' features external to the view.
     virtual void HandleMouseEvent() = 0;
     virtual void HandleMouseLeave() = 0;
 
     // The content's intrinsic width (prefWidth) changed.
     virtual void UpdatePreferredWidth(int pref_width) = 0;
-
-   protected:
-    ~View() {}
   };
 
   // RendererManagerment -------------------------------------------------------
   // Functions for managing switching of Renderers. For TabContents, this is
   // implemented by the RenderViewHostManager
 
   class RendererManagement {
    public:
     // Notification whether we should close the page, after an explicit call to
     // AttemptToClosePage.  This is called before a cross-site request or before
     // a tab/window is closed (as indicated by the first parameter) to allow the
     // appropriate renderer to approve or deny the request.  |proceed| indicates
     // whether the user chose to proceed.
     virtual void ShouldClosePage(bool for_cross_site_transition,
                                  bool proceed) = 0;
 
     // Called by ResourceDispatcherHost when a response for a pending cross-site
     // request is received.  The ResourceDispatcherHost will pause the response
     // until the onunload handler of the previous renderer is run.
     virtual void OnCrossSiteResponse(int new_render_process_host_id,
                                      int new_request_id) = 0;
 
     // Called the ResourceDispatcherHost's associate CrossSiteRequestHandler
     // when a cross-site navigation has been canceled.
     virtual void OnCrossSiteNavigationCanceled() = 0;
-
-   protected:
-    ~RendererManagement() {}
   };
 
   // BrowserIntegration --------------------------------------------------------
   // Functions that integrate with other browser services.
 
   class BrowserIntegration {
    public:
     // Notification the user has made a gesture while focus was on the
     // page. This is used to avoid uninitiated user downloads (aka carpet
     // bombing), see DownloadRequestManager for details.
@@ skipping 26 matching lines @@
     // BrowserIntegration callbacks, feel free to move it elsewhere.
     virtual void OnCrashedPlugin(const FilePath& plugin_path) = 0;
 
     // Notification that a worker process has crashed.
     virtual void OnCrashedWorker() = 0;
 
     // Notification that a request for install info has completed.
     virtual void OnDidGetApplicationInfo(
         int32 page_id,
         const webkit_glue::WebApplicationInfo& app_info) = 0;
-
-   protected:
-    ~BrowserIntegration() {}
   };
 
   // Resource ------------------------------------------------------------------
   // Notifications of resource loading events.
 
   class Resource {
    public:
     // The RenderView is starting a provisional load.
     virtual void DidStartProvisionalLoadForFrame(
         RenderViewHost* render_view_host,
@@ skipping 36 matching lines @@
     // The RenderView failed a provisional load with an error.
     virtual void DidFailProvisionalLoadWithError(
         RenderViewHost* render_view_host,
         bool is_main_frame,
         int error_code,
         const GURL& url,
         bool showing_repost_interstitial) = 0;
 
     // Notification that a document has been loaded in a frame.
     virtual void DocumentLoadedInFrame() = 0;
-
-   protected:
-    ~Resource() {}
   };
 
   // Save ----------------------------------------------------------------------
   // Interface for saving web pages.
 
   class Save {
    public:
     // Notification that we get when we receive all savable links of
     // sub-resources for the current page, their referrers and list of frames
     // (include main frame and sub frames).
     virtual void OnReceivedSavableResourceLinksForCurrentPage(
         const std::vector<GURL>& resources_list,
         const std::vector<GURL>& referrers_list,
         const std::vector<GURL>& frames_list) = 0;
 
     // Notification that we get when we receive serialized html content data of
     // a specified web page from render process. The parameter frame_url
     // specifies what frame the data belongs. The parameter data contains the
     // available data for sending. The parameter status indicates the
     // serialization status, See
     // webkit_glue::DomSerializerDelegate::PageSavingSerializationStatus for
     // the detail meaning of status.
     virtual void OnReceivedSerializedHtmlData(const GURL& frame_url,
                                               const std::string& data,
                                               int32 status) = 0;
-
-   protected:
-    ~Save() {}
   };
 
   // Printing ------------------------------------------------------------------
 
   class Printing {
    public:
     // Notification that the render view has calculated the number of printed
     // pages.
     virtual void DidGetPrintedPagesCount(int cookie, int number_pages) = 0;
 
     // Notification that the render view is done rendering one printed page.
     // This call is synchronous, the renderer is waiting on us because of the
     // EMF memory mapped data.
     virtual void DidPrintPage(
         const ViewHostMsg_DidPrintPage_Params& params) = 0;
-
-   protected:
-    ~Printing() {}
   };
 
   // FavIcon -------------------------------------------------------------------
   // Interface for the renderer to supply favicon information.
 
   class FavIcon {
    public:
     // An image that was requested to be downloaded by DownloadImage has
     // completed.
     //
     // TODO(brettw) this should be renamed DidDownloadFavIcon, and the RVH
     // function, IPC message, and the RenderView function DownloadImage should
     // all be named DownloadFavIcon.
     virtual void DidDownloadFavIcon(RenderViewHost* render_view_host,
                                     int id,
                                     const GURL& image_url,
                                     bool errored,
                                     const SkBitmap& image) = 0;
 
     // The URL for the FavIcon of a page has changed.
     virtual void UpdateFavIconURL(RenderViewHost* render_view_host,
                                   int32 page_id,
                                   const GURL& icon_url) = 0;
-
-   protected:
-    ~FavIcon() {}
   };
 
   // AutoFill ------------------------------------------------------------------
   // Interface for autofill-related functions.
 
   class Autofill {
    public:
     // Forms fillable by autofill have been detected in the page.
     virtual void AutofillFormSubmitted(
         const webkit_glue::AutofillForm& form) = 0;
 
     // Called to retrieve a list of suggestions from the web database given
     // the name of the field |field_name| and what the user has already typed
     // in the field |user_text|.  Appeals to the database thead to perform the
     // query. When the database thread is finished, the autofill manager
     // retrieves the calling RenderViewHost and then passes the vector of
     // suggestions to RenderViewHost::AutofillSuggestionsReturned.
     virtual void GetAutofillSuggestions(const std::wstring& field_name,
                                         const std::wstring& user_text,
                                         int64 node_id,
                                         int request_id) = 0;
 
     // Called when the user has indicated that she wants to remove the specified
     // autofill suggestion from the database.
     virtual void RemoveAutofillEntry(const std::wstring& field_name,
                                      const std::wstring& value) = 0;
-
-   protected:
-    ~Autofill() {}
   };
 
   // ---------------------------------------------------------------------------
 
   // Returns the current delegate associated with a feature. May return NULL if
   // there is no corresponding delegate.
   virtual View* GetViewDelegate();
   virtual RendererManagement* GetRendererManagementDelegate();
   virtual BrowserIntegration* GetBrowserIntegrationDelegate();
   virtual Resource* GetResourceDelegate();
@@ skipping 25 matching lines @@
   virtual void RenderViewCreated(RenderViewHost* render_view_host) {}
 
   // The RenderView has been constructed.
   virtual void RenderViewReady(RenderViewHost* render_view_host) {}
 
   // The RenderView died somehow (crashed or was killed by the user).
   virtual void RenderViewGone(RenderViewHost* render_view_host) {}
 
   // The RenderView is going to be deleted. This is called when each
   // RenderView is going to be destroyed
-  virtual void RenderViewDeleted(RenderViewHost* render_view_host) {}
+  virtual void RenderViewDeleted(RenderViewHost* render_view_host) { }
 
   // The RenderView was navigated to a different page.
   virtual void DidNavigate(RenderViewHost* render_view_host,
                            const ViewHostMsg_FrameNavigate_Params& params) {}
 
   // The state for the page changed and should be updated.
   virtual void UpdateState(RenderViewHost* render_view_host,
                            int32 page_id,
                            const std::string& state) {}
 
@@ skipping 124 matching lines @@
   virtual void RendererResponsive(RenderViewHost* render_view_host) {}
 
   // Notification that the RenderViewHost's load state changed.
   virtual void LoadStateChanged(const GURL& url, net::LoadState load_state) {}
 
   // Returns true if this view is used to host an external tab container.
   virtual bool IsExternalTabContainer() const;
 
   // The RenderView has inserted one css file into page.
   virtual void DidInsertCSS() {}
-
- protected:
-  ~RenderViewHostDelegate() {}
 };
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_