chrome/browser/net/resolve_proxy_msg_helper_unittest.cc - Issue 179028: Revert "Fix a ton of compiler warnings."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/net/resolve_proxy_msg_helper_unittest.cc

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/login_prompt_gtk.cc ('k') | chrome/browser/net/url_fetcher.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/net/resolve_proxy_msg_helper.h"	5 #include "chrome/browser/net/resolve_proxy_msg_helper.h"

6	6

7 #include "base/waitable_event.h"	7 #include "base/waitable_event.h"

8 #include "net/base/net_errors.h"	8 #include "net/base/net_errors.h"

9 #include "net/proxy/mock_proxy_resolver.h"	9 #include "net/proxy/mock_proxy_resolver.h"

10 #include "net/proxy/proxy_config_service.h"	10 #include "net/proxy/proxy_config_service.h"

(...skipping 207 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
218 EXPECT_EQ(url1, resolver->pending_requests()[0]->url());	218 EXPECT_EQ(url1, resolver->pending_requests()[0]->url());

219	219

220 // Delete the underlying ResolveProxyMsgHelper -- this should cancel all	220 // Delete the underlying ResolveProxyMsgHelper -- this should cancel all

221 // the requests which are outstanding.	221 // the requests which are outstanding.

222 helper.reset();	222 helper.reset();

223	223

224 // The pending requests sent to the proxy resolver should have been cancelled.	224 // The pending requests sent to the proxy resolver should have been cancelled.

225	225

226 EXPECT_EQ(0u, resolver->pending_requests().size());	226 EXPECT_EQ(0u, resolver->pending_requests().size());

227	227

228 EXPECT_TRUE(NULL == delegate.pending_result());	228 EXPECT_EQ(NULL, delegate.pending_result());

229	229

230 // It should also be the case that msg1, msg2, msg3 were deleted by the	230 // It should also be the case that msg1, msg2, msg3 were deleted by the

231 // cancellation. (Else will show up as a leak in Purify/Valgrind).	231 // cancellation. (Else will show up as a leak in Purify/Valgrind).

232 }	232 }

OLD	NEW