Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Side by Side Diff: chrome/browser/login_prompt_gtk.cc

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/login_prompt.h ('k') | chrome/browser/net/resolve_proxy_msg_helper_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/login_prompt.h" 5 #include "chrome/browser/login_prompt.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 WideToUTF8(password).c_str()); 76 WideToUTF8(password).c_str());
77 gtk_editable_select_region(GTK_EDITABLE(username_entry_), 0, -1); 77 gtk_editable_select_region(GTK_EDITABLE(username_entry_), 0, -1);
78 } 78 }
79 } 79 }
80 80
81 // LoginHandler: 81 // LoginHandler:
82 virtual void BuildViewForPasswordManager(PasswordManager* manager, 82 virtual void BuildViewForPasswordManager(PasswordManager* manager,
83 std::wstring explanation) { 83 std::wstring explanation) {
84 DCHECK(MessageLoop::current() == ui_loop_); 84 DCHECK(MessageLoop::current() == ui_loop_);
85 85
86 root_.Own(gtk_vbox_new(false, gtk_util::kContentAreaBorder)); 86 root_.Own(gtk_vbox_new(NULL, gtk_util::kContentAreaBorder));
87 GtkWidget* label = gtk_label_new(WideToUTF8(explanation).c_str()); 87 GtkWidget* label = gtk_label_new(WideToUTF8(explanation).c_str());
88 gtk_label_set_line_wrap(GTK_LABEL(label), TRUE); 88 gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
89 gtk_box_pack_start(GTK_BOX(root_.get()), label, FALSE, FALSE, 0); 89 gtk_box_pack_start(GTK_BOX(root_.get()), label, FALSE, FALSE, 0);
90 90
91 username_entry_ = gtk_entry_new(); 91 username_entry_ = gtk_entry_new();
92 gtk_entry_set_activates_default(GTK_ENTRY(username_entry_), TRUE); 92 gtk_entry_set_activates_default(GTK_ENTRY(username_entry_), TRUE);
93 93
94 password_entry_ = gtk_entry_new(); 94 password_entry_ = gtk_entry_new();
95 gtk_entry_set_activates_default(GTK_ENTRY(password_entry_), TRUE); 95 gtk_entry_set_activates_default(GTK_ENTRY(password_entry_), TRUE);
96 gtk_entry_set_visibility(GTK_ENTRY(password_entry_), FALSE); 96 gtk_entry_set_visibility(GTK_ENTRY(password_entry_), FALSE);
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 // so it doesn't try and access this when its too late. 337 // so it doesn't try and access this when its too late.
338 LoginModel* login_model_; 338 LoginModel* login_model_;
339 339
340 DISALLOW_COPY_AND_ASSIGN(LoginHandlerGtk); 340 DISALLOW_COPY_AND_ASSIGN(LoginHandlerGtk);
341 }; 341 };
342 342
343 // static 343 // static
344 LoginHandler* LoginHandler::Create(URLRequest* request, MessageLoop* ui_loop) { 344 LoginHandler* LoginHandler::Create(URLRequest* request, MessageLoop* ui_loop) {
345 return new LoginHandlerGtk(request, ui_loop); 345 return new LoginHandlerGtk(request, ui_loop);
346 } 346 }
OLDNEW
« no previous file with comments | « chrome/browser/login_prompt.h ('k') | chrome/browser/net/resolve_proxy_msg_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698