Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: chrome/browser/history/history_types.h

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TYPES_H__
6 #define CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_TYPES_H__
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/basictypes.h" 13 #include "base/basictypes.h"
14 #include "base/stack_container.h" 14 #include "base/stack_container.h"
15 #include "base/time.h" 15 #include "base/time.h"
16 #include "chrome/browser/history/snippet.h" 16 #include "chrome/browser/history/snippet.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // dirty bits will not be in sync for these copies. 66 // dirty bits will not be in sync for these copies.
67 class URLRow { 67 class URLRow {
68 public: 68 public:
69 URLRow() { 69 URLRow() {
70 Initialize(); 70 Initialize();
71 } 71 }
72 explicit URLRow(const GURL& url) : url_(url) { 72 explicit URLRow(const GURL& url) : url_(url) {
73 // Initialize will not set the URL, so our initialization above will stay. 73 // Initialize will not set the URL, so our initialization above will stay.
74 Initialize(); 74 Initialize();
75 } 75 }
76 virtual ~URLRow() {}
77 76
78 URLID id() const { return id_; } 77 URLID id() const { return id_; }
79 const GURL& url() const { return url_; } 78 const GURL& url() const { return url_; }
80 79
81 const std::wstring& title() const { 80 const std::wstring& title() const {
82 return title_; 81 return title_;
83 } 82 }
84 void set_title(const std::wstring& title) { 83 void set_title(const std::wstring& title) {
85 // The title is frequently set to the same thing, so we don't bother 84 // The title is frequently set to the same thing, so we don't bother
86 // updating unless the string has changed. 85 // updating unless the string has changed.
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 struct KeywordSearchTermVisit { 513 struct KeywordSearchTermVisit {
515 // The time of the visit. 514 // The time of the visit.
516 base::Time time; 515 base::Time time;
517 516
518 // The search term that was used. 517 // The search term that was used.
519 std::wstring term; 518 std::wstring term;
520 }; 519 };
521 520
522 } // history 521 } // history
523 522
524 #endif // CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_ 523 #endif // CHROME_BROWSER_HISTORY_HISTORY_TYPES_H__
OLDNEW
« no previous file with comments | « chrome/browser/history/history_backend.h ('k') | chrome/browser/history/starred_url_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698